Comment on Bird

• SomethingBurger@jlai.lu ⁨4⁩ ⁨weeks⁩ ago

  URLs inside code fragments should not be clickable. This is a Markdown parsing error.

  PieFed L

  source

  • StrixUralensis@tarte.nuage-libre.fr ⁨4⁩ ⁨weeks⁩ ago

    Why shouldn't they be ?

    source

    • markz@suppo.fi ⁨4⁩ ⁨weeks⁩ ago

      Code blocks are for displaying raw text, ignoring all formatting.

      source
    • mic_check_one_two@lemmy.dbzer0.com ⁨4⁩ ⁨weeks⁩ ago

      Because it’s meant to be a block of code, not something that the user is able to interact with. The point of code blocks is that you can use special characters and have them rendered as plaintext, instead of actually working as special characters. For instance, here’s the classic Reddit shrug:
      ¯_(ツ)_/¯

      Notice that the left arm is missing? That’s because the backslash and underscores are both special characters. The backslash cancels out the underscore, making the backslash disappear. Now here’s the same shrug formatted as code:

      ¯\_(ツ)_/¯ 
      

      Notice that the left arm is visible, (or at least, it should be), because none of the characters were treated as special characters. If the left arm is invisible on your client, that is actually an error in parsing the MarkDown formatting.

      source
    • cypherpunks@lemmy.ml ⁨4⁩ ⁨weeks⁩ ago

      compare the rendering of the test output (which i also wrapped in backticks to tell the markdown rendering to render it as code) on lemmy vs on piefed.

      Essentially, it is not possible to reliably identify the URLs in code (in a language that is not known to either PyFedi or its markdown parser), because they be adjacent to URL-valid characters which actually terminate the URL in whatever syntax is being used inside the code block. So, even though it is sometimes harmless to auto-linkify inside a code block, it is also often wrong and therefore should not be (and generally is not) done.

      source

      • StrixUralensis@tarte.nuage-libre.fr ⁨4⁩ ⁨weeks⁩ ago

        Oh ok, I see

        Thank you for explaining !

        source
      • cypherpunks@lemmy.ml ⁨4⁩ ⁨weeks⁩ ago

        hmm, i see my first edit to this comment got federated to piefed but subsequent edits did not; the version after subsequent edits can be seen here on the lemmy instance i’m posting from

        source
• cypherpunks@lemmy.ml ⁨4⁩ ⁨weeks⁩ ago

  URL perfectly clickable from PieFed

  PieFed W

  that is not a W… i surrounded the URL with backticks, which means it should be treated as code and not made into a link.

  cc: PyFedi developer @rimu@piefed.social

  I had a glance at the source and don’t see a very quick fix, but I think the solution involves getting rid of the auto-linkification here and instead have that be done by the markdown library. This issue indicates that the markdown library PyFedi is using is capable of doing that.

  Here is a test I wrote which I think should pass which does not currently :)

  diff --git a/tests/test_markdown_to_html.py b/tests/test_markdown_to_html.py index 329b19be…108276c5 100644 — a/tests/test_markdown_to_html.py +++ b/tests/test_markdown_to_html.py @@ -37,6 +37,12 @@ class TestMarkdownToHtml(unittest.TestCase): result = markdown_to_html(markdown) self.assertTrue(“<pre><code>code block” in result) + def test_code_block_link(self): + “”“Test code blocks formatting containing a link”“” + markdown = "\ncode block with link: example.com \n" + result = markdown_to_html(markdown) + self.assertEqual("<pre><code>code block with link: https://example.com/ ", result) it currently produces this failure: ====================================================== FAILURES ======================================================= _______________________________________ TestMarkdownToHtml.test_code_block_link _______________________________________ self = <tests.test_markdown_to_html.TestMarkdownToHtml testMethod=test_code_block_link> def test_code_block_link(self): “”“Test code blocks formatting containing a link”“” markdown = "\ncode block with link: example.com \n" result = markdown_to_html(markdown) > self.assertEqual(“<pre><code>code block with link: https://example.com/ “, result) E AssertionError: '<pre[24 chars]ink: https://example.com/ ’ != ‘<pre[24 chars]ink: <a href=“https://example.com/” rel="nofoll[61 chars]e>\n’ E - <pre><code>code block with link: https://example.com/ E + <pre><code>code block with link: <a href=“https://example.com/” rel=“nofollow ugc” target=”_blank”>https://example.com/</a> E + </code></pre> E + tests/test_markdown_to_html.py:44: AssertionError

  HTH, and thanks for writing free software!

  source

  • rimu@piefed.social ⁨4⁩ ⁨weeks⁩ ago

    That does help very much, thank you!

    I've committed a fix.

    source

    • brbposting@sh.itjust.works ⁨4⁩ ⁨weeks⁩ ago

      PieFed / @cypherpunks@lemmy.ml W

      source
  • cypherpunks@lemmy.ml ⁨4⁩ ⁨weeks⁩ ago

    oops, i read my test closer and realized it will never pass as-is due to being cribbed from another test that was using in instead of assertEqual (and the expected string not containing the closing tags) but I trust it conveys what i mean to

    source