For general purpose, I’d say 8bitdo Ultimate C.

I am a huge fan of the GameCube pad and would use it for everything if I could.

For 2D games, particularly fighting games, I’m very fond of the Saturn pad.

However, if I had to pick a best controller ever, it’s got to be the SNES pad. No question.