This is an automated archive made by the Lemmit Bot.
The original was posted on /r/opensource by /u/OrangeKonaSteel on 2025-10-19 06:05:45+00:00.
So I have a small project which has picked up some users and a small GitHub following. Every few months I get the odd PR.
The most recent one was to add config to determine which columns to show in a table in the application. The application already has a config file, which is in yaml. The PR proposes using a single string with template syntax to determine which columns to show; my preference would be to just use a list of booleans as it’s more clear.
I suggested this, and the person who raised the PR replied with a GenAI generated comment weighing up the pros and cons of each, then updated the PR to do both which I feel is unnecessary and makes it more messy and sufficient to understand.
How do people go about dealing with stuff like this? If this was at work, and the PR came from someone who works for me, I would just have a chat and ultimately would have the power to make a final decision. Ultimately I can decide whether or not to merge this, but it feels different with volunteers. I don’t want to seem a dick, but I also don’t want to merge some garbage, and then have this in my name on my public GitHub.
Any thoughts/advice? Both about this, but also in the general case?