I am a french canadian, I can assure you niche is a french word, so Nish is technically the “correct” way of pronouncing it. Never heard it pronounced the french way by americans, only neesh. Maybe it has to do on where you are in the US tho.