All of security is about trade-offs. “What does it protect me from, and what do I give up to gain that protection?”

If you need to remember a lot of passwords, then having some kind of system makes sense.

But most people don’t need to remember a lot of passwords. Most people can reasonably offload that job to a password manager.

So without knowing anything more, I’d guess it’s not good security for them.