Moneyless society doesn’t mean a post-scarcity society. There’s clearly poverty on some Federation fringe worlds. Only Earth and the other core worlds really are paradise. The others have always been implied to work towards their bettering but not being quite there yet.